/* ============================================
   UI Fixes and Uniformity Enhancements
   Applied October 6, 2025
   Fixes overlapping elements and standardizes UI
   ============================================ */

/* ============================================
   Fix Overlapping Issues
   ============================================ */

/* Ensure navigation doesn't overlap content */
.main-nav {
  position: relative;
  z-index: var(--z-sticky);
}

/* Prevent modal content overflow */
.modal-content {
  max-height: 90vh;
  overflow-y: auto;
  position: relative;
  z-index: var(--z-modal);
}

/* Fix container spacing to prevent overlap */
.container {
  max-width: var(--container-max-width);
  margin: 0 auto;
  padding: 0 var(--space-lg);
  position: relative;
}

/* Ensure main content doesn't overlap with fixed headers */
main,
.dashboard-main,
.community-main,
.racing-main,
.parts-main,
.marketplace-main {
  margin-top: 0;
  padding-top: var(--space-3xl);
  position: relative;
  z-index: var(--z-base);
}

/* Fix overlapping text in cards */
.feature-card,
.benefit-item,
.category-card,
.listing-card,
.vehicle-card {
  overflow: hidden;
  word-wrap: break-word;
  overflow-wrap: break-word;
}

/* Fix image overflow */
img {
  max-width: 100%;
  height: auto;
  display: block;
}

/* ============================================
   Standardize Button Styles
   ============================================ */

/* Ensure all buttons match home page style */
.btn,
button.btn,
a.btn {
  display: inline-flex;
  align-items: center;
  justify-content: center;
  gap: var(--space-sm);
  padding: var(--space-md) var(--space-xl);
  font-size: var(--font-size-base);
  font-weight: var(--font-weight-medium);
  line-height: 1.5;
  border: 2px solid transparent;
  border-radius: var(--radius-md);
  cursor: pointer;
  transition: all var(--transition-fast);
  text-decoration: none;
  white-space: nowrap;
  -webkit-user-select: none;
  user-select: none;
  font-family: var(--font-family-base);
}

/* Standardize button sizes */
.btn-sm,
button.btn-sm,
a.btn-sm {
  padding: var(--space-sm) var(--space-lg);
  font-size: var(--font-size-sm);
}

.btn-lg,
button.btn-lg,
a.btn-lg {
  padding: var(--space-lg) var(--space-2xl);
  font-size: var(--font-size-lg);
}

/* Ensure consistent hover effects */
.btn:hover:not(:disabled),
button.btn:hover:not(:disabled),
a.btn:hover:not(:disabled) {
  box-shadow: var(--shadow-md);
  /* Removed transform for uniformity */
}

.btn:active:not(:disabled),
button.btn:active:not(:disabled),
a.btn:active:not(:disabled) {
  transform: translateY(0);
}

/* Fix outline button consistency */
.btn-outline,
button.btn-outline,
a.btn-outline {
  background-color: transparent;
  color: var(--color-text);
  border: 2px solid var(--color-border);
}

.btn-outline:hover,
button.btn-outline:hover,
a.btn-outline:hover {
  border-color: var(--color-text);
  background-color: var(--color-bg-secondary);
}

/* ============================================
   Standardize Tab Styles
   ============================================ */

/* Uniform tab navigation across all pages */
.tab-navigation,
.community-tabs,
.racing-tabs,
.parts-tabs {
  display: flex;
  gap: var(--space-sm);
  margin-bottom: var(--space-2xl);
  border-bottom: 2px solid var(--color-border);
  overflow-x: auto;
  /* Modern scrollbar styling - progressive enhancement */
  /* Note: scrollbar-width works in Firefox & Chrome 121+, safely ignored by Safari */
  scrollbar-width: thin; /* Firefox, Chrome 121+ */
}

.tab-btn,
.community-tab-btn,
.racing-tab-btn,
.parts-tab-btn {
  padding: var(--space-md) var(--space-xl);
  background: none;
  border: none;
  border-bottom: 2px solid transparent;
  color: var(--color-text-secondary);
  font-size: var(--font-size-base);
  font-weight: var(--font-weight-medium);
  cursor: pointer;
  transition: all var(--transition-fast);
  white-space: nowrap;
  margin-bottom: -2px;
  font-family: var(--font-family-base);
}

.tab-btn:hover,
.community-tab-btn:hover,
.racing-tab-btn:hover,
.parts-tab-btn:hover {
  color: var(--color-text);
  background-color: var(--color-bg-secondary);
}

.tab-btn.active,
.community-tab-btn.active,
.racing-tab-btn.active,
.parts-tab-btn.active {
  color: var(--color-text);
  border-bottom-color: var(--color-text);
  font-weight: var(--font-weight-semibold);
}

/* Fix tab button focus to prevent overlap */
.tab-btn:focus,
.community-tab-btn:focus,
.racing-tab-btn:focus,
.parts-tab-btn:focus {
  outline: none;
  box-shadow: inset 0 0 0 2px var(--color-focus);
  border-radius: var(--radius-sm) var(--radius-sm) 0 0;
}

.tab-btn:focus-visible,
.community-tab-btn:focus-visible,
.racing-tab-btn:focus-visible,
.parts-tab-btn:focus-visible {
  outline: 2px solid var(--color-focus);
  outline-offset: -2px;
  border-radius: var(--radius-sm) var(--radius-sm) 0 0;
  z-index: 1;
}

/* ============================================
   Fix Card Consistency
   ============================================ */

/* Standardize all card styles */
.card,
.feature-card,
.benefit-item,
.category-card,
.listing-card,
.vehicle-card,
.service-card,
.reminder-card {
  background: var(--color-bg-elevated);
  border: 1px solid var(--color-border);
  border-radius: var(--radius-lg);
  padding: var(--space-xl);
  transition: all var(--transition-base);
  overflow: hidden;
  position: relative;
}

.card:hover,
.feature-card:hover,
.category-card:hover,
.listing-card:hover,
.vehicle-card:hover {
  border-color: var(--color-text);
  box-shadow: var(--shadow-lg);
  /* Removed transform: translateY(-2px) to prevent overlap issues */
}

/* ============================================
   Fix Modal Consistency - Uniform Design
   ============================================ */

/* Ensure modals don't cause layout shifts */
.modal {
  position: fixed;
  top: 0;
  left: 0;
  width: 100%;
  height: 100%;
  z-index: var(--z-modal);
  display: none;
  align-items: center;
  justify-content: center;
  padding: var(--space-lg);
  opacity: 0;
  transition: opacity var(--transition-base);
}

.modal.active {
  display: flex;
  opacity: 1;
  animation: modalFadeIn 0.3s ease-out;
}

@keyframes modalFadeIn {
  from {
    opacity: 0;
  }
  to {
    opacity: 1;
  }
}

.modal-overlay {
  position: fixed;
  top: 0;
  left: 0;
  width: 100%;
  height: 100%;
  background-color: rgba(0, 0, 0, 0.6);
  z-index: var(--z-modal-backdrop);
  -webkit-backdrop-filter: blur(8px);
  backdrop-filter: blur(8px);
}

.modal-content {
  position: relative;
  background: var(--color-bg-elevated);
  border: 1px solid var(--color-border);
  border-radius: var(--radius-xl);
  box-shadow: 0 20px 60px rgba(0, 0, 0, 0.3), 0 10px 20px rgba(0, 0, 0, 0.2);
  max-width: 600px;
  width: 100%;
  max-height: 90vh;
  overflow: hidden;
  display: flex;
  flex-direction: column;
  z-index: var(--z-modal);
  animation: modalSlideUp 0.3s cubic-bezier(0.34, 1.56, 0.64, 1);
}

@keyframes modalSlideUp {
  from {
    opacity: 0;
    transform: translateY(60px) scale(0.9);
  }
  to {
    opacity: 1;
    transform: translateY(0) scale(1);
  }
}

.modal-content.modal-lg {
  max-width: 800px;
}

.modal-content.modal-xl {
  max-width: 1000px;
}

/* Modal Header - Professional Style */
.modal-header {
  display: flex;
  justify-content: space-between;
  align-items: center;
  padding: var(--space-xl);
  border-bottom: 1px solid var(--color-border);
  background: var(--color-bg);
  flex-shrink: 0;
}

.modal-header h2,
.modal-header h3 {
  margin: 0;
  font-size: var(--font-size-xl);
  font-weight: var(--font-weight-semibold);
  color: var(--color-text);
}

/* Modal Close Button */
.modal-close {
  background: var(--color-bg-elevated);
  border: 1px solid var(--color-border);
  border-radius: var(--radius-md);
  font-size: var(--font-size-2xl);
  line-height: 1;
  cursor: pointer;
  color: var(--color-text-secondary);
  padding: 0;
  width: 36px;
  height: 36px;
  display: flex;
  align-items: center;
  justify-content: center;
  transition: all var(--transition-fast);
  flex-shrink: 0;
}

.modal-close:hover {
  color: var(--color-text);
  background: var(--color-bg-secondary);
  border-color: var(--color-text);
  transform: scale(1.1);
  box-shadow: 0 2px 8px rgba(0, 0, 0, 0.1);
}

.modal-close:active {
  transform: scale(0.95);
}

/* Modal Body - Scrollable */
.modal-body {
  padding: var(--space-xl);
  overflow-y: auto;
  flex: 1;
  /* Modern scrollbar styling - progressive enhancement */
  /* Note: These properties work in Firefox & Chrome 121+, safely ignored by Safari */
  /* WebKit browsers use the ::-webkit-scrollbar styles below as fallback */
  scrollbar-width: thin; /* Firefox, Chrome 121+ */
  scrollbar-color: var(--color-border) transparent; /* Firefox, Chrome 121+ */
}

.modal-body::-webkit-scrollbar {
  width: 8px;
}

.modal-body::-webkit-scrollbar-track {
  background: transparent;
}

.modal-body::-webkit-scrollbar-thumb {
  background: var(--color-border);
  border-radius: var(--radius-full);
}

.modal-body::-webkit-scrollbar-thumb:hover {
  background: var(--color-text-secondary);
}

/* Modal Actions */
.modal-actions {
  display: flex;
  gap: var(--space-md);
  justify-content: flex-end;
  margin-top: var(--space-xl);
  padding-top: var(--space-lg);
  border-top: 1px solid var(--color-border);
}

.modal-actions .btn {
  min-width: 100px;
}

/* ============================================
   Fix Form Consistency
   ============================================ */

/* Standardize form inputs */
.input,
.form-input,
input[type="text"],
input[type="email"],
input[type="password"],
input[type="number"],
input[type="tel"],
input[type="url"],
input[type="date"],
select,
.select,
textarea,
.textarea,
.form-textarea {
  width: 100%;
  padding: var(--space-md);
  font-family: var(--font-family-base);
  font-size: var(--font-size-base);
  color: var(--color-text);
  background-color: var(--color-bg);
  border: 1px solid var(--color-border);
  border-radius: var(--radius-md);
  transition: border-color var(--transition-fast),
    box-shadow var(--transition-fast);
  line-height: 1.5;
}

.input:focus,
.form-input:focus,
input:focus,
select:focus,
textarea:focus {
  outline: none;
  border-color: var(--color-text);
  box-shadow: 0 0 0 3px rgba(0, 0, 0, 0.05);
}

/* ============================================
   Fix Grid Layouts
   ============================================ */

/* Ensure grids don't overflow */
.grid,
.benefits-grid,
.categories-grid,
.listings-grid,
.vehicles-grid,
.members-grid {
  display: grid;
  gap: var(--space-xl);
  width: 100%;
  margin: 0 auto;
}

/* Prevent grid blowout on mobile */
@media (max-width: 768px) {
  .grid,
  .benefits-grid,
  .categories-grid,
  .listings-grid,
  .vehicles-grid,
  .members-grid {
    grid-template-columns: 1fr;
    gap: var(--space-lg);
  }

  .marketplace-layout {
    grid-template-columns: 1fr;
  }

  .marketplace-sidebar {
    position: static;
    max-height: none;
  }
}

/* ============================================
   Fix Typography Consistency
   ============================================ */

/* Standardize heading styles */
h1,
h2,
h3,
h4,
h5,
h6 {
  font-weight: var(--font-weight-bold);
  line-height: var(--line-height-tight);
  margin: 0 0 var(--space-md) 0;
  color: var(--color-text);
}

h1 {
  font-size: var(--font-size-5xl);
}

h2 {
  font-size: var(--font-size-3xl);
}

h3 {
  font-size: var(--font-size-2xl);
}

p {
  line-height: var(--line-height-normal);
  margin: 0 0 var(--space-md) 0;
}

/* ============================================
   Fix Spacing Consistency
   ============================================ */

/* Standardize section spacing */
section,
.section {
  padding: var(--space-3xl) 0;
}

.section-title {
  font-size: var(--font-size-3xl);
  font-weight: var(--font-weight-bold);
  text-align: center;
  margin-bottom: var(--space-md);
}

.section-subtitle {
  font-size: var(--font-size-lg);
  color: var(--color-text-secondary);
  text-align: center;
  margin-bottom: var(--space-2xl);
  max-width: 800px;
  margin-left: auto;
  margin-right: auto;
}

/* ============================================
   Fix Z-Index Layering
   ============================================ */

/* Ensure proper stacking order */
.main-nav {
  z-index: var(--z-sticky);
}

.dropdown,
.user-dropdown {
  z-index: var(--z-dropdown);
}

.modal-overlay {
  z-index: var(--z-modal-backdrop);
}

.modal-content {
  z-index: var(--z-modal);
}

.notification,
.toast {
  z-index: calc(var(--z-modal) + 100);
}

/* ============================================
   Fix Responsive Issues
   ============================================ */

/* Ensure content is readable on all screens */
@media (max-width: 640px) {
  .hero-title,
  h1 {
    font-size: var(--font-size-3xl);
  }

  .hero-subtitle {
    font-size: var(--font-size-base);
  }

  .btn {
    width: 100%;
    justify-content: center;
  }

  .hero-cta {
    flex-direction: column;
    width: 100%;
  }
}

/* ============================================
   Utility Classes
   ============================================ */

.hidden {
  display: none !important;
}

.visually-hidden {
  position: absolute;
  width: 1px;
  height: 1px;
  padding: 0;
  margin: -1px;
  overflow: hidden;
  clip: rect(0, 0, 0, 0);
  white-space: nowrap;
  border-width: 0;
}

.text-center {
  text-align: center;
}

.mt-0 {
  margin-top: 0;
}
.mb-0 {
  margin-bottom: 0;
}
.mt-sm {
  margin-top: var(--space-sm);
}
.mb-sm {
  margin-bottom: var(--space-sm);
}
.mt-md {
  margin-top: var(--space-md);
}
.mb-md {
  margin-bottom: var(--space-md);
}
.mt-lg {
  margin-top: var(--space-lg);
}
.mb-lg {
  margin-bottom: var(--space-lg);
}
.mt-xl {
  margin-top: var(--space-xl);
}
.mb-xl {
  margin-bottom: var(--space-xl);
}
